Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 550093005: [DirectWrite] Add support for font-stretch suffixes (Closed)

Created:
6 years, 3 months ago by eae
Modified:
6 years, 3 months ago
CC:
blink-reviews, jamesr, krit, jbroman, mkwst+moarreviews_chromium.org, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[DirectWrite] Add support for font-stretch suffixes Add support for font family names with a font-stretch suffix (such as Condensed, UltaExpanded, Narrow etc). If the full name fails to match an installed font check for a font-stretch suffix and if so strip it and set the stretch value according to the suffix. The current implementation matches IE when it comes to picking or overriding the stretch value based on the suffix. The coresponding logic for font-weight suffix matching was implemented in r181493. TEST=fast/text/font-stretch-variant.html BUG=410940 R=cpu@chromium.org, dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182061

Patch Set 1 #

Patch Set 2 : removed trailing comma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -7 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/font-stretch-variant.html View 1 chunk +46 lines, -0 lines 0 comments Download
M Source/platform/fonts/win/FontCacheSkiaWin.cpp View 1 5 chunks +57 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
eae
6 years, 3 months ago (2014-09-15 22:42:57 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
6 years, 3 months ago (2014-09-16 00:03:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/550093005/20001
6 years, 3 months ago (2014-09-16 00:09:13 UTC) #4
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-16 02:09:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/550093005/20001
6 years, 3 months ago (2014-09-16 15:19:52 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 15:52:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182061

Powered by Google App Engine
This is Rietveld 408576698