Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 550093004: Fix crash on suspend for chrome os (Closed)

Created:
6 years, 3 months ago by Chirantan Ekbote
Modified:
6 years, 3 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix crash on suspend for chrome os If RendererFreezer::SuspendImminent was called multiple times before it had a chance to report readiness, it would post multiple tasks to do so on the current message loop. However the callback to report readiness would be cleared after the first task ran and would cause a crash when the next task tried to run it. Fix this by not posting new tasks while a callback is pending and just update the callback instead. BUG=414396 Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>; Committed: https://crrev.com/1a1fd18086ffee9f111b4454098665d1c9fc0b4b Cr-Commit-Position: refs/heads/master@{#294916}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M chrome/browser/chromeos/power/renderer_freezer.cc View 2 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Chirantan Ekbote
ptal
6 years, 3 months ago (2014-09-15 21:09:39 UTC) #2
Daniel Erat
lgtm
6 years, 3 months ago (2014-09-15 21:13:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/550093004/1
6 years, 3 months ago (2014-09-15 21:15:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3e8b90c518783a5a888989cfdae75690d4059e1d
6 years, 3 months ago (2014-09-15 23:26:02 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 23:32:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a1fd18086ffee9f111b4454098665d1c9fc0b4b
Cr-Commit-Position: refs/heads/master@{#294916}

Powered by Google App Engine
This is Rietveld 408576698