Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 550093002: SWRegistration::unregister returns false when the registration is already unregistered. (3/3) (Closed)

Created:
6 years, 3 months ago by shimazu
Modified:
6 years, 3 months ago
Reviewers:
horo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@unregister_resolve_correctly
Project:
blink
Visibility:
Public.

Description

ServiceWorkerRegistration::unregister returns false when the registration is already unregistered. (3/3) 1. [Blink] https://codereview.chromium.org/549093002/ 2. [Chromium] https://codereview.chromium.org/554573002/ 3. [Blink] this patch BUG=390894 TEST=run_webkit_tests.py http/tests/serviceworker/unregister.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181783

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M LayoutTests/http/tests/serviceworker/unregister.html View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
shimazu
6 years, 3 months ago (2014-09-08 08:28:22 UTC) #2
horo
lgtm
6 years, 3 months ago (2014-09-10 05:47:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shimazu@chromium.org/550093002/1
6 years, 3 months ago (2014-09-10 08:09:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/24190)
6 years, 3 months ago (2014-09-10 09:05:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/550093002/1
6 years, 3 months ago (2014-09-11 00:08:49 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 02:40:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181783

Powered by Google App Engine
This is Rietveld 408576698