Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 550083003: Revert of Mixed Content: Move subframe checks into ResourceFetcher. (Closed)

Created:
6 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 3 months ago
Reviewers:
Mike West
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin
Project:
blink
Visibility:
Public.

Description

Revert of Mixed Content: Move subframe checks into ResourceFetcher. (patchset #2 id:40001 of https://codereview.chromium.org/544573002/) Reason for revert: calls V8 from a non-V8 context Original issue's description: > Mixed Content: Move subframe checks into ResourceFetcher. > > Currently we're checking for mixed content when loading the main > resource of subframes in two places: DocumentLoader and ResourceFetcher. > The former properly checks against the frame's parent frame, while the > latter bypasses the checks entirely by virtue of the request's > 'Resource::Type' being 'Main'. > > This is both confusing and difficult to replicate when moving to the > brave new world of request contexts and frame types that Fetch now > defines. > > This patch drops the DocumentLoader check, and moves the relevant > logic into ResourceFetcher::canRequest and > ResourceFetcher::checkInsecureContent. > > BUG=400087 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181383 TBR=mkwst@chromium.org NOTREECHECKS=true NOTRY=true BUG=400087 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181543

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -47 lines) Patch
M Source/core/fetch/ResourceFetcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 9 chunks +32 lines, -45 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Mixed Content: Move subframe checks into ResourceFetcher.
6 years, 3 months ago (2014-09-08 08:31:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/550083003/1
6 years, 3 months ago (2014-09-08 08:32:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 181543
6 years, 3 months ago (2014-09-08 08:33:11 UTC) #3
Mike West
6 years, 3 months ago (2014-09-11 07:24:40 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/559333002/ by mkwst@chromium.org.

The reason for reverting is: This wasn't the root cause of the non-V8 context
call..

Powered by Google App Engine
This is Rietveld 408576698