DescriptionRevert of Mixed Content: Move subframe checks into ResourceFetcher. (patchset #2 id:40001 of https://codereview.chromium.org/544573002/)
Reason for revert:
calls V8 from a non-V8 context
Original issue's description:
> Mixed Content: Move subframe checks into ResourceFetcher.
>
> Currently we're checking for mixed content when loading the main
> resource of subframes in two places: DocumentLoader and ResourceFetcher.
> The former properly checks against the frame's parent frame, while the
> latter bypasses the checks entirely by virtue of the request's
> 'Resource::Type' being 'Main'.
>
> This is both confusing and difficult to replicate when moving to the
> brave new world of request contexts and frame types that Fetch now
> defines.
>
> This patch drops the DocumentLoader check, and moves the relevant
> logic into ResourceFetcher::canRequest and
> ResourceFetcher::checkInsecureContent.
>
> BUG=400087
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181383
TBR=mkwst@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400087
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181543
Patch Set 1 #
Created: 6 years, 3 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|