Issue 550083002: [Mac] Fix ChromeLocatorTest on official builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 550083002: [Mac] Fix ChromeLocatorTest on official builds. (Closed)

Created:
6 years, 3 months ago by jackhou1

Modified:
6 years, 3 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

[Mac] Fix ChromeLocatorTest on official builds. This was using kBrowserProcessExecutableNameChromium, it should use kBrowserProcessExecutableName. Also revert previous changes disabling these tests. https://codereview.chromium.org/532173002/ BUG=409615 Committed: https://crrev.com/b7eac8ac9889cced43322b75c969dd5c49869569 Cr-Commit-Position: refs/heads/master@{#293877}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -28 lines)			Patch
	M	chrome/common/mac/app_mode_chrome_locator_browsertest.mm	View	1	6 chunks	+6 lines, -28 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/550083002/20001

6 years, 3 months ago (2014-09-09 00:28:46 UTC) #5

commit-bot: I haz the power

Committed patchset #2 (id:20001) as 18124f4ad06d99cb2125a59743aaad70d35ecc1a

6 years, 3 months ago (2014-09-09 06:48:22 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:51:26 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/b7eac8ac9889cced43322b75c969dd5c49869569
Cr-Commit-Position: refs/heads/master@{#293877}