DescriptionRevert of cc: Single-threaded impl-side painting for unit tests (patchset #5 id:80001 of https://codereview.chromium.org/508373002/)
Reason for revert:
LayerTreeHostContextTestDontUseLostResources.RunSingleThread_DirectRenderer_MainThreadPaint Fails on Win7 bot after this change.
Speculative revert by sheriff.
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/30957/steps/cc_unittests/logs/RunSingleThread_DirectRenderer_MainThreadPaint
Original issue's description:
> cc: Single-threaded impl-side painting for unit tests
>
> This adds methods to SingleThreadProxy to support impl-side painting
> when using the scheduler. This allows most unit tests to test impl-side
> painting classes through both the single and threaded paths.
>
> The biggest caveat to this approach is the "commit waits for activation"
> logic that mailboxes want to use. Because there is no easy way to block
> the only thread there is while activation happens, activation always
> happens immediately during commit, even if the tree is not ready. To
> cause the tree to wait to draw until it is ready, drawing is prevented
> via SetRequiresHighResToDraw. This prepares the way for the future
> where the SingleThreadProxy will likely commit directly to the active
> tree.
>
> The synchronous CompositeImmediately function does not support impl-side
> painting yet. This is the path used by everything but unit tests at
> this point.
>
> R=danakj@chromium.org
> BUG=329553
>
> Committed: https://chromium.googlesource.com/chromium/src/+/7eee8e03582772716b820001af75343f6341e6e8
TBR=danakj@chromium.org,enne@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=329553
Committed: https://crrev.com/ea769fd2090e40950c84f9df851ffec5792bf04e
Cr-Commit-Position: refs/heads/master@{#293685}
Patch Set 1 #
Created: 6 years, 3 months ago
(Patch set is too large to download)
Messages
Total messages: 6 (2 generated)
|