Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 550073002: Revert of cc: Single-threaded impl-side painting for unit tests (Closed)

Created:
6 years, 3 months ago by henrika (OOO until Aug 14)
Modified:
6 years, 3 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, reveman, vmpstr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Single-threaded impl-side painting for unit tests (patchset #5 id:80001 of https://codereview.chromium.org/508373002/) Reason for revert: LayerTreeHostContextTestDontUseLostResources.RunSingleThread_DirectRenderer_MainThreadPaint Fails on Win7 bot after this change. Speculative revert by sheriff. http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/30957/steps/cc_unittests/logs/RunSingleThread_DirectRenderer_MainThreadPaint Original issue's description: > cc: Single-threaded impl-side painting for unit tests > > This adds methods to SingleThreadProxy to support impl-side painting > when using the scheduler. This allows most unit tests to test impl-side > painting classes through both the single and threaded paths. > > The biggest caveat to this approach is the "commit waits for activation" > logic that mailboxes want to use. Because there is no easy way to block > the only thread there is while activation happens, activation always > happens immediately during commit, even if the tree is not ready. To > cause the tree to wait to draw until it is ready, drawing is prevented > via SetRequiresHighResToDraw. This prepares the way for the future > where the SingleThreadProxy will likely commit directly to the active > tree. > > The synchronous CompositeImmediately function does not support impl-side > painting yet. This is the path used by everything but unit tests at > this point. > > R=danakj@chromium.org > BUG=329553 > > Committed: https://chromium.googlesource.com/chromium/src/+/7eee8e03582772716b820001af75343f6341e6e8 TBR=danakj@chromium.org,enne@chromium.org NOTREECHECKS=true NOTRY=true BUG=329553 Committed: https://crrev.com/ea769fd2090e40950c84f9df851ffec5792bf04e Cr-Commit-Position: refs/heads/master@{#293685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -185 lines) Patch
M cc/test/layer_tree_test.h View 3 chunks +28 lines, -56 lines 0 comments Download
M cc/test/layer_tree_test.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 7 chunks +9 lines, -19 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 7 chunks +8 lines, -14 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 4 chunks +1 line, -4 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 12 chunks +23 lines, -74 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
henrika (OOO until Aug 14)
Created Revert of cc: Single-threaded impl-side painting for unit tests
6 years, 3 months ago (2014-09-08 06:51:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/550073002/1
6 years, 3 months ago (2014-09-08 07:14:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as aba2c47b1595c8fd7f85263c22e3dd67642dfedb
6 years, 3 months ago (2014-09-08 07:20:34 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:44:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea769fd2090e40950c84f9df851ffec5792bf04e
Cr-Commit-Position: refs/heads/master@{#293685}

Powered by Google App Engine
This is Rietveld 408576698