Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 550053003: Fix crash of ExtensionManagement in guest mode (Closed)

Created:
6 years, 3 months ago by binjin
Modified:
6 years, 3 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix crash of ExtensionManagement in guest mode The default BrowserContextKeyedServiceFactory::GetBrowserContextToUse() returns NULL for guest mode profile, overriding it to redirect to original profile. BUG=411763 TBR=finnur@chromium.org Committed: https://crrev.com/9733df1451a579792b8cb728b51697e03300ae5c Cr-Commit-Position: refs/heads/master@{#293729}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/extensions/extension_management.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_management.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
binjin
Joao, PTAL at this fix.
6 years, 3 months ago (2014-09-08 11:46:37 UTC) #2
Joao da Silva
lgtm
6 years, 3 months ago (2014-09-08 13:21:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binjin@chromium.org/550053003/1
6 years, 3 months ago (2014-09-08 13:32:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as ee5a24fc3674639596f125f6ef95c785e7acf096
6 years, 3 months ago (2014-09-08 15:24:52 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:46:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9733df1451a579792b8cb728b51697e03300ae5c
Cr-Commit-Position: refs/heads/master@{#293729}

Powered by Google App Engine
This is Rietveld 408576698