Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 550043003: Remove a linear search in SkPictureRecord::addTextBlob. (Closed)

Created:
6 years, 3 months ago by jbroman
Modified:
6 years, 3 months ago
Reviewers:
f(malita), mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove a linear search in SkPictureRecord::addTextBlob. It doesn't seem that harmful to have repeated text blobs in the array if they occur within the same picture recording. And that does not seem to be a common occurrence right now anyhow. BUG=skia:2919 Committed: https://skia.googlesource.com/skia/+/dd1e9f75969c72da53657e58a080c47b30f64140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M src/core/SkPictureRecord.cpp View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbroman
Is there any reason to do this search? It shows up on profiles when I ...
6 years, 3 months ago (2014-09-08 16:39:03 UTC) #2
reed1
6 years, 3 months ago (2014-09-08 18:32:49 UTC) #4
mtklein
Very LGTM This is how we record SkTextBlobs into SkRecord, no dedup.
6 years, 3 months ago (2014-09-08 19:16:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jbroman@chromium.org/550043003/1
6 years, 3 months ago (2014-09-08 20:17:43 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 20:24:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as dd1e9f75969c72da53657e58a080c47b30f64140

Powered by Google App Engine
This is Rietveld 408576698