Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: athena/wm/split_view_controller.cc

Issue 550043002: Keep the split view activities topmost in z-order in Athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: athena/wm/split_view_controller.cc
diff --git a/athena/wm/split_view_controller.cc b/athena/wm/split_view_controller.cc
index 957b8c76b750b1feef16d5b992f890cb8d958afe..1d61ba7d957e77f938fea6d216563401875f2e1b 100644
--- a/athena/wm/split_view_controller.cc
+++ b/athena/wm/split_view_controller.cc
@@ -95,18 +95,8 @@ void SplitViewController::ActivateSplitMode(aura::Window* left,
}
SetState(ACTIVE);
- if (right_window_ != right) {
- right_window_ = right;
- // Since the |window_list_provider_| controls directly the order of windows,
- // it needs to change the window order accordingly.
- window_list_provider_->MoveToFront(right_window_);
- }
- if (left_window_ != left) {
- left_window_ = left;
- // Since the |window_list_provider_| controls directly the order of windows,
- // it needs to change the window order accordingly.
- window_list_provider_->MoveToFront(left_window_);
- }
+ right_window_ = right;
+ left_window_ = left;
UpdateLayout(true);
}
@@ -179,6 +169,9 @@ void SplitViewController::UpdateLayout(bool animate) {
left_window_->Show();
right_window_->Show();
+ window_list_provider_->MoveToFront(right_window_);
+ window_list_provider_->MoveToFront(left_window_);
+
if (state_ == ACTIVE) {
if (animate) {
gfx::Transform left_transform = GetTargetTransformForBoundsAnimation(

Powered by Google App Engine
This is Rietveld 408576698