Issue 550011: Increase the size of buffer used by LogPrintf to 1600 bytes....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 550011: Increase the size of buffer used by LogPrintf to 1600 bytes.... (Closed)

Created:
10 years, 11 months ago by Alexander Potapenko

Modified:
9 years, 6 months ago

Reviewers:
_com_google_glider, willchan no longer on Chromium

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Increase the size of buffer used by LogPrintf to 1600 bytes. 600 bytes is not enough to print full symbolized stacks of the memory leaks. TBR=willchan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36011

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/tcmalloc/chromium/src/base/logging.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

On 2010/01/12 15:45:23, Alexander Potapenko wrote: > LGTM I assume you plan to upstream this ...

10 years, 11 months ago (2010-01-12 17:02:57 UTC) #2

_com_google_glider

10 years, 11 months ago (2010-01-13 06:21:53 UTC) #3

> I assume you plan to upstream this change, right?

I do. Maybe the proposed fix is too straight to convince the perftools people,
but I can work out a more flexible solution then.

Expand Messages | Collapse Messages