Mojo: WebSocket interface now reuses the DataPipe for subsequent sends or

mojo/services/public/interfaces/network/web_socket.mojom

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 import "mojo/services/public/interfaces/network/network_error.mojom"
 
 module mojo {
 
 interface WebSocket {
   enum MessageType {
     CONTINUATION,
     TEXT,
     BINARY
   };
   const uint16 kAbnormalCloseCode = 1006;  // stolen from websocket_bridge
 
-  Connect(
-      string url, string[] protocols, string origin, WebSocketClient client);
-  Send(bool fin, MessageType type, handle<data_pipe_consumer> data);
+  Connect(string url,

[darin (slow to review), 2014/09/19 05:40:08]

nit: please document the protocol here. it is not immediately obvious how
send_stream and the Send method are related. the other methods really could use
some documentation as well.

[Matt Perry, 2014/09/19 19:50:45]

I documented Send/Receive/Connect and explained the data pipes. I didn't
document the other methods because I don't actually know what they do (beyond
the obvious) and couldn't find any documentation.

+          string[] protocols,
+          string origin,
+          handle<data_pipe_consumer> send_stream,
+          WebSocketClient client);
+  Send(bool fin, MessageType type, uint32 num_bytes);
   FlowControl(int64 quota);
   Close(uint16 code, string reason);
 };
 
 interface WebSocketClient {
-  DidConnect(bool fail, string selected_subprotocol, string extensions);
-  DidReceiveData(
-      bool fin, WebSocket.MessageType type, handle<data_pipe_consumer> data);
+  DidConnect(bool fail,
+             string selected_subprotocol,
+             string extensions,
+             handle<data_pipe_consumer> receive_stream);
+  DidReceiveData(bool fin, WebSocket.MessageType type, uint32 num_bytes);
   DidReceiveFlowControl(int64 quota);
   DidFail(string message);
   DidClose(bool was_clean, uint16 code, string reason);
 
   // Blink has 3 extra methods that we don't implement, because they are used
   // for the inspector:
   // didStartOpeningHandshake
   // didFinishOpeningHandshake
   // didStartClosingHandshake
 };
 
 }