Hide "New incognito window" from jump list if disabled by policy.

chrome/browser/jumplist_win.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_JUMPLIST_WIN_H_
 #define CHROME_BROWSER_JUMPLIST_WIN_H_
 
 #include <list>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/files/file_path.h"
 #include "base/memory/weak_ptr.h"
 #include "base/synchronization/lock.h"
 #include "base/task/cancelable_task_tracker.h"
 #include "chrome/browser/history/history_service.h"
 #include "chrome/browser/history/history_types.h"
 #include "chrome/browser/jumplist_updater_win.h"
+#include "chrome/browser/prefs/incognito_mode_prefs.h"
 #include "chrome/browser/sessions/tab_restore_service.h"
 #include "chrome/browser/sessions/tab_restore_service_observer.h"
 #include "content/public/browser/browser_thread.h"
 
 namespace chrome {
 struct FaviconImageResult;
 }
 
 namespace content {
 class NotificationRegistrar;
 }
 
+class PageUsageData;
+class PrefChangeRegistrar;
 class Profile;
-class PageUsageData;
 
 // A class which implements an application JumpList.
 // This class encapsulates operations required for updating an application
 // JumpList:
 // * Retrieving "Most Visited" pages from HistoryService;
 // * Retrieving strings from the application resource;
 // * Creatng COM objects used by JumpList from PageUsageData objects;
 // * Adding COM objects to JumpList, etc.
 //
 // This class also implements TabRestoreServiceObserver. So, once we call
 // AddObserver() and register this class as an observer, it automatically

[sky, 2014/09/08 16:15:17]

Update comments and what not about new functionality. AddObserver is a poor name
too (as is AddObservers). SetProfile is a better name.

[Joao da Silva, 2014/09/08 16:44:10]

Turns out that there is a single user of this class so it's quite easy to
sanitize the API and just pass the Profile in the ctor.

Removed AbbObserver and RemoveObserver.

 // updates a JumpList when a tab is added or removed.
 //
 // Updating a JumpList requires some file operations and it is not good to
 // update it in a UI thread. To solve this problem, this class posts to a
 // runnable method when it actually updates a JumpList.
 //
 // Note. base::CancelableTaskTracker is not thread safe, so we
 // always delete JumpList on UI thread (the same thread it got constructed on).
 class JumpList : public TabRestoreServiceObserver,
                  public content::NotificationObserver,
@@ skipping 58 matching lines @@
   void OnFaviconDataAvailable(
       const favicon_base::FaviconImageResult& image_result);
 
   // Callback for TopSites that notifies when the "Most
   // Visited" list is available. This function updates the ShellLinkItemList
   // objects and send another query that retrieves a favicon for each URL in
   // the list.
   void OnMostVisitedURLsAvailable(
       const history::MostVisitedURLList& data);
 
+  // Callback for changes to the incognito mode availability pref.
+  void OnIncognitoAvailabilityChanged();

[sky, 2014/09/08 16:15:17]

Can this and the PostRunUpdate be private?

[Joao da Silva, 2014/09/08 16:44:10]

Done.

+
+  // Helper for RunUpdate() that determines its parameters.
+  void PostRunUpdate();
+
   // Runnable method that updates the jumplist, once all the data
   // has been fetched.
-  void RunUpdate();
+  void RunUpdate(IncognitoModePrefs::Availability incognito_availability);
 
   // Helper method for RunUpdate to create icon files for the asynchrounously
   // loaded icons.
   void CreateIconFiles(const ShellLinkItemList& item_list);
 
  private:
   friend struct content::BrowserThread::DeleteOnThread<
       content::BrowserThread::UI>;
   friend class base::DeleteHelper<JumpList>;
   ~JumpList();
 
   // For callbacks may be run after destruction.
   base::WeakPtrFactory<JumpList> weak_ptr_factory_;
 
   // Tracks FaviconService tasks.
   base::CancelableTaskTracker cancelable_task_tracker_;
 
   // The Profile object is used to listen for events
   Profile* profile_;
 
   // Lives on the UI thread.
   scoped_ptr<content::NotificationRegistrar> registrar_;
+  scoped_ptr<PrefChangeRegistrar> pref_change_registrar_;
 
   // App id to associate with the jump list.
   std::wstring app_id_;
 
   // The directory which contains JumpList icons.
   base::FilePath icon_dir_;
 
   // Items in the "Most Visited" category of the application JumpList,
   // protected by the list_lock_.
   ShellLinkItemList most_visited_pages_;
@@ skipping 12 matching lines @@
   base::CancelableTaskTracker::TaskId task_id_;
 
   // Lock for most_visited_pages_, recently_closed_pages_, icon_urls_
   // as they may be used by up to 3 threads.
   base::Lock list_lock_;
 
   DISALLOW_COPY_AND_ASSIGN(JumpList);
 };
 
 #endif  // CHROME_BROWSER_JUMPLIST_WIN_H_