Window controls

Window controls

Also fixes:
. a bug in NVVM where the WTH is reset. It's also reset by the NWA it subclasses, resulting in a UAF.
. needed some more schedulepaints in display manager to handle the window being removed. I am running into what looks like a bug/misunderstanding w/schedule paint, but I decided not to worry about it since this code is getting blown up once james lands.

R=sky@chromium.org
BUG=none

Committed: https://crrev.com/9054c441bc68f2ea55722bb3b5de469c45317eee
Cr-Commit-Position: refs/heads/master@{#294528}

[Ben Goodger (Google), 2014-09-11 18:22:24]

ben@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2014-09-11 19:32:23]

https://codereview.chromium.org/549883003/diff/80001/mojo/examples/wm_flow/wm...
File mojo/examples/wm_flow/wm/frame_controller.cc (right):

https://codereview.chromium.org/549883003/diff/80001/mojo/examples/wm_flow/wm...
mojo/examples/wm_flow/wm/frame_controller.cc:24: const int kButtonFrameMargin =
5;
nit: make these static, otherwise they should be named kFoo.

https://codereview.chromium.org/549883003/diff/80001/mojo/examples/wm_flow/wm...
mojo/examples/wm_flow/wm/frame_controller.cc:56: if (sender == close_button_) {
nit: no {}

https://codereview.chromium.org/549883003/diff/80001/mojo/examples/wm_flow/wm...
mojo/examples/wm_flow/wm/frame_controller.cc:97: mojo::View* first_child =
view_->children().front();
It's worth documenting why you need to delete only the first child.

https://codereview.chromium.org/549883003/diff/80001/mojo/examples/wm_flow/wm...
File mojo/examples/wm_flow/wm/frame_controller.h (right):

https://codereview.chromium.org/549883003/diff/80001/mojo/examples/wm_flow/wm...
mojo/examples/wm_flow/wm/frame_controller.h:26: virtual ~FrameController();
You never delete instances of this.

https://codereview.chromium.org/549883003/diff/80001/mojo/services/view_manag...
File mojo/services/view_manager/connection_manager.cc (right):

https://codereview.chromium.org/549883003/diff/80001/mojo/services/view_manag...
mojo/services/view_manager/connection_manager.cc:268:
display_manager_.SchedulePaint(old_parent, old_parent->bounds());
I think you want gfx::Rect(old_parent()->bounds().size()) here and
gfx::Rect(new_parent->bounds().size()) below.

[Ben Goodger (Google), 2014-09-11 20:13:30]

updated.

[sky, 2014-09-11 20:24:40]

LGTM

[Ben Goodger (Google), 2014-09-12 01:36:15]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2014-09-12 01:37:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/549883003/140001

[commit-bot: I haz the power, 2014-09-12 02:31:45]

Committed patchset #8 (id:140001) as 483ad2ad7aad69e28763a697e53dad47a5c4aa30

[commit-bot: I haz the power, 2014-09-12 02:42:38]

Patchset 8 (id:??) landed as
https://crrev.com/9054c441bc68f2ea55722bb3b5de469c45317eee
Cr-Commit-Position: refs/heads/master@{#294528}