Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1420)

Unified Diff: mojo/public/tools/bindings/mojom.gni

Issue 549863004: Make ui gn check pass. Misc GN build improvements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix utility linking Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/generated_extensions_api.gni ('k') | tools/gn/input_file_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/tools/bindings/mojom.gni
diff --git a/mojo/public/tools/bindings/mojom.gni b/mojo/public/tools/bindings/mojom.gni
index eeb32bd6efb500b4cb023a031ca471d2cfaa6258..816edf77c9fd105eb54be9e6d3c1b220f9a694b5 100644
--- a/mojo/public/tools/bindings/mojom.gni
+++ b/mojo/public/tools/bindings/mojom.gni
@@ -12,8 +12,10 @@
# List of source .mojom files to compile.
#
# deps (optional)
+#
# visibility (optional)
-# Normal meaning.
+# Normal meaning. However, this must be a list (normal visibility
+# allows a single string).
template("mojom") {
assert(defined(invoker.sources),
"\"sources\" must be defined for the $target_name template.")
« no previous file with comments | « extensions/generated_extensions_api.gni ('k') | tools/gn/input_file_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698