Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1766)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 54983012: Add a new version of RenderViewImpl::createView() with a suppress_opener flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 408 matching lines...) Expand 10 before | Expand all | Expand 10 after
419 bool event_cancelled) OVERRIDE; 419 bool event_cancelled) OVERRIDE;
420 virtual void initializeLayerTreeView() OVERRIDE; 420 virtual void initializeLayerTreeView() OVERRIDE;
421 421
422 // WebKit::WebViewClient implementation -------------------------------------- 422 // WebKit::WebViewClient implementation --------------------------------------
423 423
424 virtual WebKit::WebView* createView( 424 virtual WebKit::WebView* createView(
425 WebKit::WebFrame* creator, 425 WebKit::WebFrame* creator,
426 const WebKit::WebURLRequest& request, 426 const WebKit::WebURLRequest& request,
427 const WebKit::WebWindowFeatures& features, 427 const WebKit::WebWindowFeatures& features,
428 const WebKit::WebString& frame_name, 428 const WebKit::WebString& frame_name,
429 WebKit::WebNavigationPolicy policy,
430 bool suppress_opener);
Charlie Reis 2013/11/04 18:54:56 Would this make sense on WebWindowFeatures?
431 // DEPRECATED
432 virtual WebKit::WebView* createView(
433 WebKit::WebFrame* creator,
434 const WebKit::WebURLRequest& request,
435 const WebKit::WebWindowFeatures& features,
436 const WebKit::WebString& frame_name,
429 WebKit::WebNavigationPolicy policy); 437 WebKit::WebNavigationPolicy policy);
430 virtual WebKit::WebWidget* createPopupMenu(WebKit::WebPopupType popup_type); 438 virtual WebKit::WebWidget* createPopupMenu(WebKit::WebPopupType popup_type);
431 virtual WebKit::WebExternalPopupMenu* createExternalPopupMenu( 439 virtual WebKit::WebExternalPopupMenu* createExternalPopupMenu(
432 const WebKit::WebPopupMenuInfo& popup_menu_info, 440 const WebKit::WebPopupMenuInfo& popup_menu_info,
433 WebKit::WebExternalPopupMenuClient* popup_menu_client); 441 WebKit::WebExternalPopupMenuClient* popup_menu_client);
434 virtual WebKit::WebStorageNamespace* createSessionStorageNamespace(); 442 virtual WebKit::WebStorageNamespace* createSessionStorageNamespace();
435 virtual bool shouldReportDetailedMessageForSource( 443 virtual bool shouldReportDetailedMessageForSource(
436 const WebKit::WebString& source); 444 const WebKit::WebString& source);
437 virtual void didAddMessageToConsole( 445 virtual void didAddMessageToConsole(
438 const WebKit::WebConsoleMessage& message, 446 const WebKit::WebConsoleMessage& message,
(...skipping 1103 matching lines...) Expand 10 before | Expand all | Expand 10 after
1542 // use the Observer interface to filter IPC messages and receive frame change 1550 // use the Observer interface to filter IPC messages and receive frame change
1543 // notifications. 1551 // notifications.
1544 // --------------------------------------------------------------------------- 1552 // ---------------------------------------------------------------------------
1545 1553
1546 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1554 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
1547 }; 1555 };
1548 1556
1549 } // namespace content 1557 } // namespace content
1550 1558
1551 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1559 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698