Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 54983009: [GN] Make an include path relative to src/ (Closed)

Created:
7 years, 1 month ago by tzik
Modified:
7 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make an include path relative to src/ NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/input_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tzik
Hi, Brett. Can I make a tiny include path fix?
7 years, 1 month ago (2013-11-01 17:08:15 UTC) #1
brettw
lgtm
7 years, 1 month ago (2013-11-05 05:41:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/54983009/1
7 years, 1 month ago (2013-11-05 05:49:00 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219486
7 years, 1 month ago (2013-11-05 08:58:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/54983009/1
7 years, 1 month ago (2013-11-05 09:05:09 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97850
7 years, 1 month ago (2013-11-05 12:22:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/54983009/1
7 years, 1 month ago (2013-11-05 12:24:25 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 14:17:29 UTC) #8
Message was sent while issue was closed. 
Change committed as 232977

Powered by Google App Engine
This is Rietveld 408576698