Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 549753002: Cleanup bits of base::ProcessMetrics. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
awong
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup bits of base::ProcessMetrics. Committed: https://crrev.com/a0d051ed00e459f970a784e1419ba26414824fc6 Cr-Commit-Position: refs/heads/master@{#293791}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : fix a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -158 lines) Patch
M base/process/process_metrics.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M base/process/process_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_metrics_linux.cc View 10 chunks +116 lines, -153 lines 0 comments Download
M base/process/process_metrics_mac.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Lei Zhang
https://codereview.chromium.org/549753002/diff/20001/base/process/process_metrics.cc File base/process/process_metrics.cc (left): https://codereview.chromium.org/549753002/diff/20001/base/process/process_metrics.cc#oldcode56 base/process/process_metrics.cc:56: NOTIMPLEMENTED(); // http://crbug.com/20488 typo https://codereview.chromium.org/549753002/diff/20001/base/process/process_metrics.h File base/process/process_metrics.h (right): https://codereview.chromium.org/549753002/diff/20001/base/process/process_metrics.h#newcode205 ...
6 years, 3 months ago (2014-09-06 09:31:58 UTC) #3
awong
rubberstamp LGTM
6 years, 3 months ago (2014-09-06 15:34:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/549753002/40001
6 years, 3 months ago (2014-09-07 06:17:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/9723)
6 years, 3 months ago (2014-09-07 08:23:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/549753002/40001
6 years, 3 months ago (2014-09-08 18:27:12 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001) as d6887b8d8904348069fb3e0660eef17ae1057e6e
6 years, 3 months ago (2014-09-08 21:46:07 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:48:20 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a0d051ed00e459f970a784e1419ba26414824fc6
Cr-Commit-Position: refs/heads/master@{#293791}

Powered by Google App Engine
This is Rietveld 408576698