Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 549713004: Add more logging to ShowAndFocusNativeWindow. (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add more logging to ShowAndFocusNativeWindow. I'm seeing my previous logging with empty window titles. TBR=sky Committed: https://crrev.com/06a12b2e4a0410bfa479c9751e17252f1a69f612 Cr-Commit-Position: refs/heads/master@{#294557}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M chrome/test/base/interactive_test_utils_win.cc View 2 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
jam
6 years, 3 months ago (2014-09-12 06:01:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/549713004/40001
6 years, 3 months ago (2014-09-12 06:01:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/55099) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/14439) ios_rel_device ...
6 years, 3 months ago (2014-09-12 06:05:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/549713004/60001
6 years, 3 months ago (2014-09-12 06:12:52 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/55102) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/14442) ios_rel_device ...
6 years, 3 months ago (2014-09-12 06:15:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/549713004/80001
6 years, 3 months ago (2014-09-12 06:42:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/549713004/100001
6 years, 3 months ago (2014-09-12 06:59:34 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:100001) as 89db22fb3e53230590baab5d97fab5d65b3f6acb
6 years, 3 months ago (2014-09-12 09:22:58 UTC) #20
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/06a12b2e4a0410bfa479c9751e17252f1a69f612 Cr-Commit-Position: refs/heads/master@{#294557}
6 years, 3 months ago (2014-09-12 09:29:17 UTC) #21
sky
6 years, 3 months ago (2014-09-12 15:44:42 UTC) #22
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698