Issue 549713002: GN: Exclude libvpx NEON intrinsics in ARM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 549713002: GN: Exclude libvpx NEON intrinsics in ARM (Closed)

Created:
6 years, 3 months ago by Alpha Left Google

Modified:
6 years, 3 months ago

Reviewers:
Tom Finegan

CC:
chromium-reviews, wwcv, jzern, fgalligan1

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/libvpx/

Project:
chromium_deps

Visibility:
Public.

GN: Exclude libvpx NEON intrinsics in ARM NEON intrinsics are not building yet on ARM. Exclude them. TBR=tomfinegan@chromium.org

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	BUILD.gn	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Alpha Left Google

Committed patchset #1 (id:1) manually as r291843 (presubmit successful).

6 years, 3 months ago (2014-09-06 02:55:03 UTC) #1

Tom Finegan

6 years, 3 months ago (2014-09-09 20:03:34 UTC) #3

Message was sent while issue was closed.

On 2014/09/06 03:13:14, Alpha wrote:

lgtm minus the media_use_libvpx (which you already fixed, and I'm only aware of
because of your fix :))