Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 549663002: Move AppWindowGeometryCacheTest to extensions_unittests (Closed)

Created:
6 years, 3 months ago by James Cook
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move AppWindowGeometryCacheTest to extensions_unittests It was running in Chrome's unit_tests for historical reasons. * Remove usage of Chrome's TestExtensionPrefs by instantiating our own simplified ExtensionPrefs. * Move ShellAppSorting to NullAppSorting so it can be used for the above as well as app_shell. BUG=397164 TEST=extensions_unittests Committed: https://crrev.com/b9129716d465383c2bf08b2c550f5af1205b2232 Cr-Commit-Position: refs/heads/master@{#293768}

Patch Set 1 #

Patch Set 2 : (app-window) rebase 1 #

Patch Set 3 : (app-window) rebase 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -236 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/app_window/app_window_geometry_cache_unittest.cc View 15 chunks +98 lines, -32 lines 0 comments Download
A + extensions/browser/null_app_sorting.h View 2 chunks +9 lines, -9 lines 0 comments Download
A + extensions/browser/null_app_sorting.cc View 2 chunks +22 lines, -22 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 chunks +4 lines, -0 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
D extensions/shell/browser/shell_app_sorting.h View 1 chunk +0 lines, -63 lines 0 comments Download
D extensions/shell/browser/shell_app_sorting.cc View 1 chunk +0 lines, -105 lines 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
James Cook
rockot, PTAL After moving ShellAppSorting to share code it ended up being pretty straightforward.
6 years, 3 months ago (2014-09-05 23:49:16 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-06 02:43:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/549663002/1
6 years, 3 months ago (2014-09-07 00:05:57 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-07 02:06:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/549663002/40001
6 years, 3 months ago (2014-09-08 18:02:27 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 95719c18f408331383eabb6bd135d2878dc87104
6 years, 3 months ago (2014-09-08 19:30:25 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:47:37 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b9129716d465383c2bf08b2c550f5af1205b2232
Cr-Commit-Position: refs/heads/master@{#293768}

Powered by Google App Engine
This is Rietveld 408576698