build/common.gypi - Issue 54963005: Upstream printing changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 54963005: Upstream printing changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleanup Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 38167b32a973084a1be49b4588fa194c7f2ae55b..ebbb5cd162b0e58b9bfa0649c64dc55ab1d9ab95 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -541,12 +541,9 @@

# Enable basic printing for Chrome for Android but disable printing

# completely for WebView.

joth 2013/11/04 20:30:38 needs update

sgurun-gerrit only 2013/11/21 18:25:43 Done.

- ['OS=="android" and android_webview_build==0', {

+ ['OS=="android"', {

Peter Beverloo 2013/11/12 13:38:29 You can also consolidate this with the conditional

sgurun-gerrit only 2013/11/21 18:25:43 good point. On 2013/11/12 13:38:29, Peter Beverlo

'enable_printing%': 2,

}],

- ['OS=="android" and android_webview_build==1', {

- 'enable_printing%': 0,

- }],

# Android OS includes support for proprietary codecs regardless of

# building Chromium or Google Chrome. We also ship Google Chrome with