Issue 54963004: Make LoadableTextTrack::clearClient not virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 54963004: Make LoadableTextTrack::clearClient not virtual (Closed)

Created:
7 years, 1 month ago by philipj_slow

Modified:
7 years, 1 month ago

Reviewers:
Nate Chapin

CC:
blink-reviews, dglazkov+blink, nessy, vcarbune.chromium, philipj_slow, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Make LoadableTextTrack::clearClient not virtual When TextTrack::clearClient and LoadableTextTrack::clearClient were added in r99984, both had the virtual keyword and nothing seemed odd. In r135410 the virtual keyword was dropped from TextTrack::clearClient because "it is unnecessary", but LoadableTextTrack::clearClient was left virtual even though it now shadowed (instead of overriding) TextTrack. The HTMLTrackElement destructor calls LoadableTextTrack::clearClient, so there's no risk of LoadableTextTrack::m_trackElement becoming stale. It would be nice to sort this out even more, perhaps by refactoring LoadableTextTrack into a TextTrackCueProvider or something that doesn't inherit from TextTrack, but until then add a comment to calm the reader. BUG=313287 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161197

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	Source/core/html/track/LoadableTextTrack.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/54963004/1

7 years, 1 month ago (2013-11-01 19:46:45 UTC) #3

Message was sent while issue was closed.

Change committed as 161197

Expand Messages | Collapse Messages