content/browser/android/content_view_core_impl.cc - Issue 549603003: Create Mojo service for locking/unlocking screen orientation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 549603003: Create Mojo service for locking/unlocking screen orientation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to review, port unittest Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/browser/screen_orientation/screen_orientation_service_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/content_view_core_impl.cc

diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc

index 3afa104ab1e5826fadf59a8bdae5ec1f2bd3dfc1..437051a17806ee95bd4c209a3f28e8b4d307e482 100644

--- a/content/browser/android/content_view_core_impl.cc

+++ b/content/browser/android/content_view_core_impl.cc

@@ -32,6 +32,7 @@

#include "content/browser/renderer_host/render_view_host_impl.h"

#include "content/browser/renderer_host/render_widget_host_impl.h"

#include "content/browser/renderer_host/render_widget_host_view_android.h"

+#include "content/browser/screen_orientation/screen_orientation_context.h"

#include "content/browser/transition_request_manager.h"

#include "content/browser/web_contents/web_contents_view_android.h"

#include "content/common/frame_messages.h"

@@ -42,7 +43,6 @@

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/favicon_status.h"

#include "content/public/browser/render_frame_host.h"

-#include "content/public/browser/screen_orientation_dispatcher_host.h"

#include "content/public/browser/ssl_host_state_delegate.h"

#include "content/public/browser/web_contents.h"

#include "content/public/common/content_client.h"

@@ -1254,8 +1254,9 @@ void ContentViewCoreImpl::SendOrientationChangeEventInternal() {

if (rwhv)

rwhv->UpdateScreenInfo(GetViewAndroid());

- static_cast<WebContentsImpl*>(web_contents())->

- screen_orientation_dispatcher_host()->OnOrientationChange();

+ static_cast<WebContentsImpl*>(web_contents())

+ ->screen_orientation_context()

+ ->OnScreenOrientationChange();

}

void ContentViewCoreImpl::ExtractSmartClipData(JNIEnv* env,