Create Mojo service for locking/unlocking screen orientation.

content/public/browser/screen_orientation_dispatcher_host.h

Index: content/public/browser/screen_orientation_dispatcher_host.h
diff --git a/content/public/browser/screen_orientation_dispatcher_host.h b/content/public/browser/screen_orientation_dispatcher_host.h
deleted file mode 100644
index c0f8bc0268fbdd3e1b7c94724149697d53edf502..0000000000000000000000000000000000000000
--- a/content/public/browser/screen_orientation_dispatcher_host.h
+++ /dev/null
@@ -1,36 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CONTENT_PUBLIC_BROWSER_SCREEN_ORIENTATION_DISPATCHER_HOST_H_
-#define CONTENT_PUBLIC_BROWSER_SCREEN_ORIENTATION_DISPATCHER_HOST_H_
-
-#include "content/common/content_export.h"
-#include "third_party/WebKit/public/platform/WebLockOrientationError.h"
-
-namespace content {
-
-// ScreenOrientationDispatcherHost receives lock and unlock requests from the
-// RenderFrames and dispatch them to the ScreenOrientationProvider. It also
-// make sure that the right RenderFrame get replied for each lock request.
-class CONTENT_EXPORT ScreenOrientationDispatcherHost {
- public:
-  virtual ~ScreenOrientationDispatcherHost() {}
-
-  // Notifies that the lock with the given |request_id| has succeeded.
-  // The renderer process will be notified that the lock succeeded only if

[blundell, 2014/09/18 09:52:46]

Mounir, AFAICT, |request_id| will always match the current lock information in
the current implementation if the ScreenOrientationDispatcherHost has non-NULL
current lock information. My new implementation does not track request IDs on
the browser side. Is there a corner case that I'm not seeing where that will
cause ScreenOrientationServiceImpl to incorrectly call back the renderer on
receiving a NotifyLockResult() call from the ScreenOrientationProvider?

-  // |request_id| matches the current lock information.
-  virtual void NotifyLockSuccess(int request_id) = 0;
-
-  // Notifies that the lock with the given |request_id| has failed.
-  // The renderer process will be notified that the lock succeeded only if
-  // |request_id| matches the current lock information.
-  virtual void NotifyLockError(int request_id,
-                               blink::WebLockOrientationError error) = 0;
-
-  virtual void OnOrientationChange() = 0;
-};
-
-}  // namespace content
-
-#endif // CONTENT_PUBLIC_BROWSER_SCREEN_ORIENTATION_DISPATCHER_HOST_H_