Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 549583003: Make HPACK static table static and immutable. (Closed)

Created:
6 years, 3 months ago by Bence
Modified:
6 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make HPACK static table static and immutable. Create HpackStaticTable singleton class, so that every HPACK context can share a constant instance of the static table. This lands server change 74862865 by bnc. BUG=400336 Committed: https://crrev.com/d4ec60089740b0613792208ee57ff2ffccb2b6f5 Cr-Commit-Position: refs/heads/master@{#293710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+392 lines, -229 lines) Patch
M net/net.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M net/spdy/hpack_constants.h View 2 chunks +19 lines, -1 line 0 comments Download
M net/spdy/hpack_constants.cc View 3 chunks +102 lines, -0 lines 0 comments Download
M net/spdy/hpack_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_decoder_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack_encoder.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M net/spdy/hpack_encoder_test.cc View 3 chunks +11 lines, -8 lines 0 comments Download
M net/spdy/hpack_header_table.h View 7 chunks +15 lines, -17 lines 0 comments Download
M net/spdy/hpack_header_table.cc View 7 chunks +48 lines, -117 lines 0 comments Download
M net/spdy/hpack_header_table_test.cc View 17 chunks +51 lines, -80 lines 0 comments Download
A net/spdy/hpack_static_table.h View 1 chunk +46 lines, -0 lines 0 comments Download
A net/spdy/hpack_static_table.cc View 1 chunk +38 lines, -0 lines 0 comments Download
A net/spdy/hpack_static_table_test.cc View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
PTAL. Thank you.
6 years, 3 months ago (2014-09-05 21:59:55 UTC) #2
Ryan Hamilton
lgtm
6 years, 3 months ago (2014-09-05 22:08:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bnc@chromium.org/549583003/1
6 years, 3 months ago (2014-09-08 11:51:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as d40b00e7f2fa249e4c04784e7ccd1bd2f5572688
6 years, 3 months ago (2014-09-08 12:37:24 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:45:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4ec60089740b0613792208ee57ff2ffccb2b6f5
Cr-Commit-Position: refs/heads/master@{#293710}

Powered by Google App Engine
This is Rietveld 408576698