Exit if pngcrush has a bug

Exit if pngcrush has a bug

BUG=404893
Committed: https://crrev.com/074d0df916f864830f1885a8997ef7029079a364
Cr-Commit-Position: refs/heads/master@{#293631}

[oshima, 2014-09-05 18:45:36]

Patchset #1 (id:1) has been deleted

[oshima, 2014-09-05 18:47:15]

Patchset #1 (id:20001) has been deleted

[oshima, 2014-09-05 18:47:30]

oshima@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2014-09-05 19:05:43]

https://codereview.chromium.org/549553002/diff/40001/tools/resources/optimize...
File tools/resources/optimize-png-files.sh (right):

https://codereview.chromium.org/549553002/diff/40001/tools/resources/optimize...
tools/resources/optimize-png-files.sh:389: if [[ (1748 -lt $version_num &&
$version_num -lt 1773) ]] ; then
How did you find this range? I'd like to be sure that 1.7.73 and onward does not
have this defect. Will Ubuntu 14.04 LTS users have a clear path to upgrade?
(should we instruct them that they'll need to build source from xyz, since
Ubuntu's package manager only grabs 1.7.65-0.1, and there don't seem to be other
prebuilt Linux binaries?)

[oshima, 2014-09-05 20:18:42]

On 2014/09/05 19:05:43, msw wrote:
>
https://codereview.chromium.org/549553002/diff/40001/tools/resources/optimize...
> File tools/resources/optimize-png-files.sh (right):
> 
>
https://codereview.chromium.org/549553002/diff/40001/tools/resources/optimize...
> tools/resources/optimize-png-files.sh:389: if [[ (1748 -lt $version_num &&
> $version_num -lt 1773) ]] ; then
> How did you find this range? I'd like to be sure that 1.7.73 and onward does
not
> have this defect. Will Ubuntu 14.04 LTS users have a clear path to upgrade?
> (should we instruct them that they'll need to build source from xyz, since
> Ubuntu's package manager only grabs 1.7.65-0.1, and there don't seem to be
other
> prebuilt Linux binaries?)

I've got the number from glenn (looks like he sent me directly. I'll forward).
This is a best effort to catch known issue as there is no way to ensure a bug
does not exist in pngcrush (and other tools as well) without tests.

[msw, 2014-09-05 20:22:40]

Okay, it still seems unclear how to upgrade, but LGTM.

[oshima, 2014-09-05 21:26:57]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-09-05 21:29:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/549553002/40001

[commit-bot: I haz the power, 2014-09-06 03:31:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-06 03:31:36]

Exceeded time limit waiting for builds to trigger.

[oshima, 2014-09-06 20:01:33]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-09-06 20:02:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/549553002/40001

[commit-bot: I haz the power, 2014-09-06 20:05:22]

Committed patchset #1 (id:40001) as da3d0f13c2cb0b6109fb90c2e284ceaae2bb7b21

[commit-bot: I haz the power, 2014-09-10 03:43:14]

Patchset 1 (id:??) landed as
https://crrev.com/074d0df916f864830f1885a8997ef7029079a364
Cr-Commit-Position: refs/heads/master@{#293631}