Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 54953002: Adjust placement of innerHTML (Closed)

Created:
7 years, 1 month ago by davve
Modified:
7 years, 1 month ago
Reviewers:
felt
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, felt, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adjust placement of innerHTML In Blink rev 160981, innerHTML was moved from HTMLElement to Element. Adjust UmaPolicy to match the new placement. BUG=311080 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/activity_log/uma_policy.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
davve
My grep found this and it looks reasonable to change even though I don't have ...
7 years, 1 month ago (2013-10-31 15:58:04 UTC) #1
felt
Thanks, yes, this does need to be changed as well.
7 years, 1 month ago (2013-10-31 17:35:35 UTC) #2
felt
lgtm
7 years, 1 month ago (2013-10-31 17:35:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/54953002/1
7 years, 1 month ago (2013-10-31 19:03:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/54953002/1
7 years, 1 month ago (2013-10-31 23:55:25 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217064
7 years, 1 month ago (2013-11-01 03:01:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/54953002/1
7 years, 1 month ago (2013-11-01 07:39:47 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-01 14:59:33 UTC) #8
Message was sent while issue was closed.
Change committed as 232388

Powered by Google App Engine
This is Rietveld 408576698