Issue 549513002: Return 1 from git_cl land when you Ctrl-C it in the middle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 549513002: Return 1 from git_cl land when you Ctrl-C it in the middle. (Closed)

Created:
6 years, 3 months ago by iannucci

Modified:
6 years, 3 months ago

Reviewers:
agable, Michael Moss

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Project:
tools

Visibility:
Public.

More Reviews

Description

Return 1 from git_cl land when you Ctrl-C it in the middle. R=agable@chromium.org, mmoss@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291823

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix nit #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	git_cl.py	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Moss

lgtm https://codereview.chromium.org/549513002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/549513002/diff/1/git_cl.py#newcode2049 git_cl.py:2049: pass nit: remove pass

6 years, 3 months ago (2014-09-05 17:23:25 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/549513002/20001

6 years, 3 months ago (2014-09-05 18:24:06 UTC) #4

commit-bot: I haz the power

6 years, 3 months ago (2014-09-05 18:25:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 291823

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages