athena/wm/window_list_provider_impl.cc - Issue 549453005: Run athena on device

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/wm/window_list_provider_impl.cc

Issue 549453005: Run athena on device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: athena/wm/window_list_provider_impl.cc

diff --git a/athena/wm/window_list_provider_impl.cc b/athena/wm/window_list_provider_impl.cc

index 6c6580f777d1900b0f1a84c3fc8ee927de850518..02c54ef68f5a6c681d536b8fab0d9fdffc28ac77 100644

--- a/athena/wm/window_list_provider_impl.cc

+++ b/athena/wm/window_list_provider_impl.cc

@@ -53,7 +53,9 @@ bool WindowListProviderImpl::IsWindowInList(aura::Window* window) const {

}

bool WindowListProviderImpl::IsValidWindow(aura::Window* window) const {

- return window->type() == ui::wm::WINDOW_TYPE_NORMAL;

+ // TODO(oshima): crbug.com/413912

+ return window->type() == ui::wm::WINDOW_TYPE_NORMAL ||

+ window->type() == ui::wm::WINDOW_TYPE_PANEL;

}

void WindowListProviderImpl::MoveToFront(aura::Window* window) {