Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 549453005: Run athena on device (Closed)

Created:
6 years, 3 months ago by oshima
Modified:
6 years, 3 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, sadrul, nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, yuzo+watch_chromium.org, dtseng+watch_chromium.org, pam+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, ben+ash_chromium.org, dmazzoni+watch_chromium.org, flackr, Dmitry Polukhin, Nikita (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Run athena on device Added CHECKs in static methods in ash::Shell/RootWindowController to identify the chrome code accessing ash BUG=410444 TBR=sky@chromium.org TEST=tested on Pixel Committed: https://crrev.com/9eea82dadf7749b42d09d8f423db99cab2a01a72 Cr-Commit-Position: refs/heads/master@{#294717}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -21 lines) Patch
M ash/root_window_controller.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/shell.cc View 3 chunks +6 lines, -1 line 0 comments Download
M athena/main/athena_launcher.cc View 3 chunks +15 lines, -4 lines 0 comments Download
M athena/wm/window_list_provider_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 10 chunks +16 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/dbus/cros_dbus_service.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/first_run/first_run_controller.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 1 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/memory/oom_priority_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/fullscreen_chromeos.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_talk_host.cc View 1 2 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
oshima
6 years, 3 months ago (2014-09-12 22:12:32 UTC) #7
Dmitry Polukhin
lgtm https://codereview.chromium.org/549453005/diff/100001/chrome/browser/chromeos/login/lock/screen_locker.cc File chrome/browser/chromeos/login/lock/screen_locker.cc (right): https://codereview.chromium.org/549453005/diff/100001/chrome/browser/chromeos/login/lock/screen_locker.cc#newcode375 chrome/browser/chromeos/login/lock/screen_locker.cc:375: // crbug.com/370175. I think we need separate issue ...
6 years, 3 months ago (2014-09-12 22:20:58 UTC) #9
oshima
https://codereview.chromium.org/549453005/diff/100001/chrome/browser/chromeos/login/lock/screen_locker.cc File chrome/browser/chromeos/login/lock/screen_locker.cc (right): https://codereview.chromium.org/549453005/diff/100001/chrome/browser/chromeos/login/lock/screen_locker.cc#newcode375 chrome/browser/chromeos/login/lock/screen_locker.cc:375: // crbug.com/370175. On 2014/09/12 22:20:58, Dmitry Polukhin wrote: > ...
6 years, 3 months ago (2014-09-12 22:24:15 UTC) #10
Jun Mukai
lgtm
6 years, 3 months ago (2014-09-12 23:27:42 UTC) #11
oshima
tbr'ing sky for ifdef USE_ATHENA in chrome/browser
6 years, 3 months ago (2014-09-12 23:33:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/549453005/140001
6 years, 3 months ago (2014-09-12 23:46:26 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:140001) as b5e1c547a15dbae5c51c5c8157e2ac8f98fc7594
6 years, 3 months ago (2014-09-13 01:12:18 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 01:19:10 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/9eea82dadf7749b42d09d8f423db99cab2a01a72
Cr-Commit-Position: refs/heads/master@{#294717}

Powered by Google App Engine
This is Rietveld 408576698