GN: Fix compile errors with os==chromeos mojo/public build

GN: Fix compile errors with os==chromeos mojo/public build

The big changes here are:
1) Allow injecting of a target toolchain via args for os==chromeos.
2) For ARM builds, allow injecting -mtune and -mfloat-abi settings.
3) Allow injecting a pkg-config wrapper that correctly handles the
   CrOS build environment. This is how pkg-config is handled for
   all other packages in the build.
4) Create libmojo_sdk target, a static library of public Mojo code
   suitable for distribution.
5) Added testonly = true to a few targets under mojo/ that are not
   meant to be used in production.

BUG=388412
TEST=Create a target that builds //mojo/public, build with os==chromeos

Committed: https://crrev.com/2c8e745d9c4de27b44f4d866a2bf0f0a880d9b8c
Cr-Commit-Position: refs/heads/master@{#296849}

[Chris Masone, 2014-09-18 20:38:08]

Brett, does this toolchain-injection stuff pass muster? This is in line with a
thread I started on gn-dev last week or so.

[Chris Masone, 2014-09-19 21:01:56]

Ping?

[Chris Masone, 2014-09-19 23:15:22]

cmasone@chromium.org changed reviewers:
+ brettw@chromium.org

[Chris Masone, 2014-09-19 23:16:09]

Hmph. I coulda _sworn_ I set a reviewer on this thing.

Brett, does this toolchain-injection stuff pass muster? This is in line with a
thread I started on gn-dev last week or so.

[Chris Masone, 2014-09-23 18:42:40]

Brett, is this heading in a usable direction? Or are there some fundamental
flaws, here?

[brettw, 2014-09-23 19:59:58]

On 2014/09/23 18:42:40, Chris Masone wrote:
> Brett, is this heading in a usable direction? Or are there some fundamental
> flaws, here?

Sorry, I lost this. Will look soon.

[brettw, 2014-09-23 20:20:17]

Overall this seems fine, just some comment requests.

https://codereview.chromium.org/549453004/diff/20001/build/config/arm.gni
File build/config/arm.gni (right):

https://codereview.chromium.org/549453004/diff/20001/build/config/arm.gni#new...
build/config/arm.gni:16: arm_tune = ""
Can you document these params?

https://codereview.chromium.org/549453004/diff/20001/build/config/linux/pkg_c...
File build/config/linux/pkg_config.gni (right):

https://codereview.chromium.org/549453004/diff/20001/build/config/linux/pkg_c...
build/config/linux/pkg_config.gni:28: pkg_config = ""
Documentation?

https://codereview.chromium.org/549453004/diff/20001/build/toolchain/cros/BUI...
File build/toolchain/cros/BUILD.gn (right):

https://codereview.chromium.org/549453004/diff/20001/build/toolchain/cros/BUI...
build/toolchain/cros/BUILD.gn:9: cros_target_cc = ""
Documentation.

[Chris Masone, 2014-09-23 22:33:58]

cmasone@chromium.org changed reviewers:
+ jamesr@chromium.org

[Chris Masone, 2014-09-23 22:33:59]

PTAL (+jamesr for OWNERS in mojo/)

https://codereview.chromium.org/549453004/diff/20001/build/config/arm.gni
File build/config/arm.gni (right):

https://codereview.chromium.org/549453004/diff/20001/build/config/arm.gni#new...
build/config/arm.gni:16: arm_tune = ""
On 2014/09/23 20:20:17, brettw wrote:
> Can you document these params?

Done.

https://codereview.chromium.org/549453004/diff/20001/build/config/linux/pkg_c...
File build/config/linux/pkg_config.gni (right):

https://codereview.chromium.org/549453004/diff/20001/build/config/linux/pkg_c...
build/config/linux/pkg_config.gni:28: pkg_config = ""
On 2014/09/23 20:20:17, brettw wrote:
> Documentation?

Done.

https://codereview.chromium.org/549453004/diff/20001/build/toolchain/cros/BUI...
File build/toolchain/cros/BUILD.gn (right):

https://codereview.chromium.org/549453004/diff/20001/build/toolchain/cros/BUI...
build/toolchain/cros/BUILD.gn:9: cros_target_cc = ""
On 2014/09/23 20:20:17, brettw wrote:
> Documentation.

Done.

[jamesr, 2014-09-23 22:56:06]

mojo/ lgtm

can you update the patch description to reflect that you're also adding this sdk
type?

why is this is_chromeos only?  The sdk target is not particular to chromeos

[Chris Masone, 2014-09-23 23:14:07]

On 2014/09/23 22:56:06, jamesr wrote:
> mojo/ lgtm
> 
> can you update the patch description to reflect that you're also adding this
sdk
> type?
> 
> why is this is_chromeos only?  The sdk target is not particular to chromeos

Updated description, added libmojo_sdk to //mojo/public on all platforms

[jamesr, 2014-09-23 23:15:15]

I don't see the updated description but the build changes look cool.

[Chris Masone, 2014-09-23 23:15:58]

On 2014/09/23 23:14:07, Chris Masone wrote:
> On 2014/09/23 22:56:06, jamesr wrote:
> > mojo/ lgtm
> > 
> > can you update the patch description to reflect that you're also adding this
> sdk
> > type?
> > 
> > why is this is_chromeos only?  The sdk target is not particular to chromeos
> 
> Updated description, added libmojo_sdk to //mojo/public on all platforms

?

Oh, I updated my local git commit message, but that doesn't get pushed up to
codereview, I guess. Bleh.

[Chris Masone, 2014-09-24 05:01:09]

The CQ bit was checked by cmasone@chromium.org

[commit-bot: I haz the power, 2014-09-24 05:01:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/549453004/60001

[commit-bot: I haz the power, 2014-09-24 05:10:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-24 05:10:50]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Chris Masone, 2014-09-24 20:15:27]

On 2014/09/24 05:10:50, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Hey, Brett. I guess James isn't an OWNER for build/{config,toolchain}

[jamesr, 2014-09-24 20:26:30]

And I didn't review those bits either, I only reviewed mojo/

[jamesr, 2014-09-24 20:26:50]

On 2014/09/23 22:56:06, jamesr wrote:
> mojo/ lgtm

^^ that's what I said.  You need to get lgtms for the whole patch before
landing.

[Chris Masone, 2014-09-24 20:29:04]

Yes, I know, but Brett's only requests on his previous pass were for some
additional comments, which I added.

On Wed, Sep 24, 2014 at 1:26 PM, <jamesr@chromium.org> wrote:

> On 2014/09/23 22:56:06, jamesr wrote:
>
>> mojo/ lgtm
>>
>
> ^^ that's what I said.  You need to get lgtms for the whole patch before
> landing.
>
> https://codereview.chromium.org/549453004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Chris Masone, 2014-09-26 01:08:13]

Ping, Brett? Does this look good to you, given the comments I added?

[brettw, 2014-09-26 01:12:42]

LGTM. Sorry, I thought I had finished this.

[Chris Masone, 2014-09-26 01:19:51]

The CQ bit was checked by cmasone@chromium.org

[commit-bot: I haz the power, 2014-09-26 01:21:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/549453004/60001

[commit-bot: I haz the power, 2014-09-26 01:28:09]

Committed patchset #4 (id:60001) as 3d708a94218060d4bbbfbcfbf2c2f536b92883e3

[commit-bot: I haz the power, 2014-09-26 01:28:45]

Patchset 4 (id:??) landed as
https://crrev.com/2c8e745d9c4de27b44f4d866a2bf0f0a880d9b8c
Cr-Commit-Position: refs/heads/master@{#296849}