Fix the logic for computing the number of truncated QUIC ACK frames sent.

net/quic/quic_connection_logger_unittest.cc

Index: net/quic/quic_connection_logger_unittest.cc
diff --git a/net/quic/quic_connection_logger_unittest.cc b/net/quic/quic_connection_logger_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1e686e7cc4298dd9cb48c19dac8787fe63ded786
--- /dev/null
+++ b/net/quic/quic_connection_logger_unittest.cc
@@ -0,0 +1,43 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.

[eroman, 2014/09/09 00:08:01]

welcome to 2014

[Ryan Hamilton, 2014/09/09 19:00:36]

Get off my lawn! :>

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/quic/quic_connection_logger.h"
+
+#include "net/quic/quic_protocol.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace net {
+namespace test {
+
+class QuicConnectionLoggerPeer {
+ public:
+  static size_t num_truncated_acks_sent(const QuicConnectionLogger& logger) {
+    return logger.num_truncated_acks_sent_;
+  }
+};
+
+class QuicConnectionLoggerTest : public ::testing::Test {
+ protected:
+  QuicConnectionLoggerTest() : logger_(net_log_) {}
+
+  BoundNetLog net_log_;
+  QuicConnectionLogger logger_;
+};
+
+TEST_F(QuicConnectionLoggerTest, TruncatedAcksSent) {
+  QuicAckFrame frame;
+  logger_.OnFrameAddedToPacket(QuicFrame(&frame));
+  EXPECT_EQ(0u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_));
+
+  for (QuicPacketSequenceNumber i = 0; i < 512; i += 2) {
+    frame.missing_packets.insert(i);
+  }
+
+  logger_.OnFrameAddedToPacket(QuicFrame(&frame));
+  EXPECT_EQ(1u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_));
+}

[eroman, 2014/09/09 00:08:01]

can you add a test where truncation does not occur?

[Ryan Hamilton, 2014/09/09 19:00:36]

Done. (That happened implicitly when the empty frame was processed, but better
to be explicit)

+
+
+}  // namespace test
+}  // namespace net