Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 549433004: Revert of Adding Text Selection Action Bar Unit Test cases. (Closed)

Created:
6 years, 3 months ago by arv (Not doing code reviews)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding Text Selection Action Bar Unit Test cases. (patchset #11 id:190001 of https://codereview.chromium.org/521583003/) Reason for revert: This is breaking on Android Tests (dbg) Original issue's description: > Adding Text Selection Action Bar Unit Test cases. > > Currently there is not enough unit test cases available to cover > the functionality of Text Selection Action Bar. In this patch covering > essentail unit test cases for the same. > > BUG= > > Committed: https://chromium.googlesource.com/chromium/src/+/7da8be70e45d91995fb4476713d7920ce77cb90f TBR=jdduke@chromium.org,aurimas@chromium.org,ajith.v@samsung.com NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/40487350c687da3373752942192bfc97dc397b03 Cr-Commit-Position: refs/heads/master@{#293730}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -105 lines) Patch
D content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java View 1 chunk +0 lines, -105 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
arv (Not doing code reviews)
Created Revert of Adding Text Selection Action Bar Unit Test cases.
6 years, 3 months ago (2014-09-08 15:22:27 UTC) #1
arv (Not doing code reviews)
keishi FYI
6 years, 3 months ago (2014-09-08 15:23:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/549433004/1
6 years, 3 months ago (2014-09-08 15:25:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 26b438a70931629e2ac91c5f789503bf2f660836
6 years, 3 months ago (2014-09-08 15:28:35 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:46:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40487350c687da3373752942192bfc97dc397b03
Cr-Commit-Position: refs/heads/master@{#293730}

Powered by Google App Engine
This is Rietveld 408576698