Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 549413003: [ew] Move operation observers from QuotaUtil to FileSystemBackend. (Closed)

Created:
6 years, 3 months ago by mtomasz
Modified:
6 years, 3 months ago
Reviewers:
tzik, Paweł Hajdan Jr.
CC:
chromium-reviews, vandebo (ex-Chrome), nkostylev+watch_chromium.org, Lei Zhang, jam, Greg Billock, nhiroki, tommycli, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org, kinuko
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ew] Move operation observers from QuotaUtil to FileSystemBackend. Soon the storage::WatcherManager interface instantiations will want to be an observer for operations. However, not all backends which have storage::WatcherManager have storage::QuotaUtil. To resolve this issue, this CL moves the observer lists one level up to the storage::FileSystemBackend. TEST=Just refactoring. Current tests should pass. BUG=261491 Committed: https://crrev.com/110ffbe98fd296a6e77328d0b963813bf5635533 Cr-Commit-Position: refs/heads/master@{#294367}

Patch Set 1 #

Patch Set 2 : Fixed. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -138 lines) Patch
M chrome/browser/chromeos/fileapi/file_system_backend.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/fileapi/file_system_backend.cc View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_backend.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_backend.cc View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/local/sync_file_system_backend.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/local/sync_file_system_backend.cc View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M content/public/test/sandbox_file_system_test_helper.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/test/test_file_system_backend.h View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M content/public/test/test_file_system_backend.cc View 1 2 5 chunks +20 lines, -54 lines 0 comments Download
M storage/browser/fileapi/file_system_backend.h View 2 chunks +16 lines, -0 lines 0 comments Download
M storage/browser/fileapi/file_system_context.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M storage/browser/fileapi/file_system_quota_util.h View 2 chunks +0 lines, -23 lines 0 comments Download
M storage/browser/fileapi/isolated_file_system_backend.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M storage/browser/fileapi/isolated_file_system_backend.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M storage/browser/fileapi/plugin_private_file_system_backend.h View 1 3 chunks +7 lines, -18 lines 0 comments Download
M storage/browser/fileapi/plugin_private_file_system_backend.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_system_backend.h View 1 chunk +6 lines, -0 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_system_backend.cc View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_system_backend_delegate.h View 1 2 chunks +18 lines, -15 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
mtomasz
On 2014/09/09 04:49:37, mtomasz wrote: > mailto:mtomasz@chromium.org changed reviewers: > + mailto:tzik@chromium.org (+cc @kinuko) @tzik: ...
6 years, 3 months ago (2014-09-09 04:56:17 UTC) #2
tzik
On 2014/09/09 04:56:17, mtomasz wrote: > On 2014/09/09 04:49:37, mtomasz wrote: > > mailto:mtomasz@chromium.org changed ...
6 years, 3 months ago (2014-09-09 05:15:17 UTC) #3
tzik
lgtm
6 years, 3 months ago (2014-09-09 07:00:34 UTC) #4
mtomasz
On 2014/09/09 07:00:34, tzik wrote: > lgtm @tzik: Shall I create a webkit/browser/fileapi/task_runner_bound_observer_list.h forward to ...
6 years, 3 months ago (2014-09-09 09:19:10 UTC) #5
tzik
On 2014/09/09 09:19:10, mtomasz wrote: > On 2014/09/09 07:00:34, tzik wrote: > > lgtm > ...
6 years, 3 months ago (2014-09-09 14:01:08 UTC) #6
mtomasz
On 2014/09/09 14:01:08, tzik wrote: > On 2014/09/09 09:19:10, mtomasz wrote: > > On 2014/09/09 ...
6 years, 3 months ago (2014-09-10 01:18:10 UTC) #7
mtomasz
@phajdan.jr: PTAL at content/public/test/*. Thanks.
6 years, 3 months ago (2014-09-10 01:21:17 UTC) #9
Paweł Hajdan Jr.
content/public/test LGTM
6 years, 3 months ago (2014-09-11 09:13:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/549413003/20001
6 years, 3 months ago (2014-09-11 09:14:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/9516)
6 years, 3 months ago (2014-09-11 09:19:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/549413003/40001
6 years, 3 months ago (2014-09-11 09:37:47 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 85ffe8b87dc23dc2d9e5e177e21d447dda9475a7
6 years, 3 months ago (2014-09-11 10:36:43 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 10:39:56 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/110ffbe98fd296a6e77328d0b963813bf5635533
Cr-Commit-Position: refs/heads/master@{#294367}

Powered by Google App Engine
This is Rietveld 408576698