Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 549353003: [NaCl SDK] nacl_io: Fix FuseFs.{read,write} (Closed)

Created:
6 years, 3 months ago by binji
Modified:
6 years, 3 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] nacl_io: Fix FuseFs.{read,write} I misinterpreted the docs as meaning that read() and write() should always return the number of bytes requested. What it actually says is that the functions should always return the number of bytes requested _unless_ the EOF is reached or there is an error. BUG=411557 R=sbc@chromium.org Committed: https://crrev.com/49b78e743721747e1b41ad055c0d9999b65a1510 Cr-Commit-Position: refs/heads/master@{#294018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M native_client_sdk/src/libraries/nacl_io/fusefs/fuse_fs.cc View 2 chunks +1 line, -6 lines 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/fuse_fs_test.cc View 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
binji
6 years, 3 months ago (2014-09-08 23:11:15 UTC) #1
Sam Clegg
lgtm
6 years, 3 months ago (2014-09-08 23:33:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/549353003/1
6 years, 3 months ago (2014-09-09 20:58:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 25409b974340c9875997d2aa68bec876982e86fd
6 years, 3 months ago (2014-09-09 21:41:43 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:55:57 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49b78e743721747e1b41ad055c0d9999b65a1510
Cr-Commit-Position: refs/heads/master@{#294018}

Powered by Google App Engine
This is Rietveld 408576698