Always send the ET_GESTURE_END event as the last one for every touch event.

Always send the ET_GESTURE_END event as the last one for every touch 
event.

Occasionally we synthesize scroll or tap cancel events when a touch 
sequence has been canceled or terminated, we want to make sure that 
ET_GESTURE_END always happens after them.

BUG=379772
Committed: https://crrev.com/3914c25088c75525c0aa3cfcdf544faa1ec09bce
Cr-Commit-Position: refs/heads/master@{#294010}

[lanwei, 2014-09-08 22:55:44]

Patchset #1 (id:1) has been deleted

[lanwei, 2014-09-08 22:57:18]

Patchset #1 (id:20001) has been deleted

[lanwei, 2014-09-08 22:59:46]

lanwei@chromium.org changed reviewers:
+ jdduke@chromium.org, tdresser@chromium.org

[jdduke (slow), 2014-09-08 23:12:51]

Maybe a brief sentence in the description about how this is necessary because we
occasionally synthesize scroll or tap cancel events when a touch sequence has
terminated?

https://codereview.chromium.org/549333002/diff/40001/ui/events/gesture_detect...
File ui/events/gesture_detection/touch_disposition_gesture_filter.cc (right):

https://codereview.chromium.org/549333002/diff/40001/ui/events/gesture_detect...
ui/events/gesture_detection/touch_disposition_gesture_filter.cc:234:
SendGesture(gesture, packet);
We should probably DCHECK_EQ(-1, gesture_end_index); here to make sure we never
get a dangling GESTURE_END with a timeout gesture. Actually, hmm, maybe we
should instead do |DCHECK_EQ(1U, packet.gesture_count());

https://codereview.chromium.org/549333002/diff/40001/ui/events/gesture_detect...
ui/events/gesture_detection/touch_disposition_gesture_filter.cc:238:
gesture_end_index = i;
|DCHECK_EQ(-1, gesture_end_index);| before assignment to make sure a given
packet only contains but one end gesture.

https://codereview.chromium.org/549333002/diff/40001/ui/events/gesture_detect...
ui/events/gesture_detection/touch_disposition_gesture_filter.cc:255: }
Nit: No need for brace if the if condition and the if body are both one liners.

[tdresser, 2014-09-09 12:16:54]

Nice!

LGTM

https://codereview.chromium.org/549333002/diff/40001/ui/events/gesture_detect...
File ui/events/gesture_detection/touch_disposition_gesture_filter.cc (right):

https://codereview.chromium.org/549333002/diff/40001/ui/events/gesture_detect...
ui/events/gesture_detection/touch_disposition_gesture_filter.cc:239: continue;
Can you add a comment about why this is necessary? (Similar to the comment Jared
asked you to add to the CL description)

[lanwei, 2014-09-09 16:17:40]

Patchset #2 (id:60001) has been deleted

[lanwei, 2014-09-09 17:55:52]

https://codereview.chromium.org/549333002/diff/40001/ui/events/gesture_detect...
File ui/events/gesture_detection/touch_disposition_gesture_filter.cc (right):

https://codereview.chromium.org/549333002/diff/40001/ui/events/gesture_detect...
ui/events/gesture_detection/touch_disposition_gesture_filter.cc:234:
SendGesture(gesture, packet);
On 2014/09/08 23:12:51, jdduke wrote:
> We should probably DCHECK_EQ(-1, gesture_end_index); here to make sure we
never
> get a dangling GESTURE_END with a timeout gesture. Actually, hmm, maybe we
> should instead do |DCHECK_EQ(1U, packet.gesture_count());

Done.

https://codereview.chromium.org/549333002/diff/40001/ui/events/gesture_detect...
ui/events/gesture_detection/touch_disposition_gesture_filter.cc:238:
gesture_end_index = i;
On 2014/09/08 23:12:51, jdduke wrote:
> |DCHECK_EQ(-1, gesture_end_index);| before assignment to make sure a given
> packet only contains but one end gesture.

Done.

https://codereview.chromium.org/549333002/diff/40001/ui/events/gesture_detect...
ui/events/gesture_detection/touch_disposition_gesture_filter.cc:239: continue;
On 2014/09/09 12:16:54, tdresser wrote:
> Can you add a comment about why this is necessary? (Similar to the comment
Jared
> asked you to add to the CL description)

Done.

https://codereview.chromium.org/549333002/diff/40001/ui/events/gesture_detect...
ui/events/gesture_detection/touch_disposition_gesture_filter.cc:255: }
On 2014/09/08 23:12:51, jdduke wrote:
> Nit: No need for brace if the if condition and the if body are both one
liners.

Done.

[jdduke (slow), 2014-09-09 18:09:28]

lgtm, thanks!

[lanwei, 2014-09-09 18:16:52]

The CQ bit was checked by lanwei@chromium.org

[commit-bot: I haz the power, 2014-09-09 18:21:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lanwei@chromium.org/549333002/80001

[commit-bot: I haz the power, 2014-09-09 19:09:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-09 19:09:02]

Try jobs failed on following builders:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[lanwei, 2014-09-09 19:34:13]

The CQ bit was checked by lanwei@chromium.org

[commit-bot: I haz the power, 2014-09-09 19:58:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lanwei@chromium.org/549333002/100001

[commit-bot: I haz the power, 2014-09-09 21:21:55]

Committed patchset #3 (id:100001) as 95b336ebbed85afc184a3f673788fb2f1cef09d1

[commit-bot: I haz the power, 2014-09-10 03:55:41]

Patchset 3 (id:??) landed as
https://crrev.com/3914c25088c75525c0aa3cfcdf544faa1ec09bce
Cr-Commit-Position: refs/heads/master@{#294010}