tools/memory_inspector/memory_inspector/frontends/www_server.py - Issue 549313006: [Android] memory_inspector: move to libheap_profiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/memory_inspector/memory_inspector/frontends/www_server.py

Issue 549313006: [Android] memory_inspector: move to libheap_profiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mi3_prebuilts

Patch Set: Add prebuilts Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/memory_inspector/memory_inspector/frontends/www_content/js/processes.js ('k') | tools/memory_inspector/prebuilts/heap_dump-android-arm.sha1 » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/memory_inspector/memory_inspector/frontends/www_server.py

diff --git a/tools/memory_inspector/memory_inspector/frontends/www_server.py b/tools/memory_inspector/memory_inspector/frontends/www_server.py

index 84fdc81a0dd162e0016096f2fceeffcee9c4e3e8..d8054f2a15b833e9765d96bd61f8e494d7a837a5 100644

--- a/tools/memory_inspector/memory_inspector/frontends/www_server.py

+++ b/tools/memory_inspector/memory_inspector/frontends/www_server.py

@@ -582,9 +582,9 @@ def _LoadNheapFromStorage(args, req_vars):

resp = {

'cols': [

- {'label': 'Total size [KB]', 'type':'number'},

- {'label': 'Alloc size [B]', 'type':'number'},

- {'label': 'Count', 'type':'number'},

+ {'label': 'Allocated', 'type':'number'},

+ {'label': 'Resident', 'type':'number'},

+ {'label': 'Flags', 'type':'number'},

{'label': 'Stack Trace', 'type':'string'},

'rows': []}

@@ -602,9 +602,9 @@ def _LoadNheapFromStorage(args, req_vars):

strace += '</dl>'

resp['rows'] += [{'c': [

- {'v': alloc.total_size, 'f': alloc.total_size / 1024},

- {'v': alloc.size, 'f': None},

- {'v': alloc.count, 'f': None},

+ {'v': alloc.size, 'f': _StrMem(alloc.size)},

+ {'v': 0, 'f': 0}, # TODO(primiano): support resident_size (next CLs).

+ {'v': alloc.flags, 'f': None},

{'v': strace, 'f': None},

]}]

return _HTTP_OK, [], resp