Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: tools/memory_inspector/memory_inspector/core/native_heap.py

Issue 549313006: [Android] memory_inspector: move to libheap_profiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mi3_prebuilts
Patch Set: Add prebuilts Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/memory_inspector/memory_inspector/core/native_heap.py
diff --git a/tools/memory_inspector/memory_inspector/core/native_heap.py b/tools/memory_inspector/memory_inspector/core/native_heap.py
index 11c903168d9ade81b997ab7bd5e377be0120b5b6..ab52a3927a0e86d721f919c9a76d3b898c799498 100644
--- a/tools/memory_inspector/memory_inspector/core/native_heap.py
+++ b/tools/memory_inspector/memory_inspector/core/native_heap.py
@@ -40,21 +40,27 @@ class NativeHeap(object):
class Allocation(object):
- """A Native allocation, modeled in a size*count fashion.
+ """Records profiling information aobut a native heap allocation.
- |count| is the number of identical stack_traces which performed the allocation
- of |size| bytes.
+ Args:
+ size: size of the allocation, in bytes.
+ stack_trace: the allocation call-site. See |stacktrace.Stacktrace|.
+ start: (Optional) Absolute start address in the process VMA. Optional.
+ It is required only for |CalculateResidentSize|.
+ flags: (Optional) More details about the call site (e.g., mmap vs malloc).
"""
- def __init__(self, size, count, stack_trace):
+ def __init__(self, size, stack_trace, start=0, flags=0):
+ assert(size > 0)
assert(isinstance(stack_trace, stacktrace.Stacktrace))
self.size = size # in bytes.
- self.count = count
self.stack_trace = stack_trace
+ self.start = start # Optional, for using the resident size logic.
+ self.flags = flags
@property
- def total_size(self):
- return self.size * self.count
+ def end(self):
+ return self.start + self.size - 1
def __str__(self):
- return '%d x %d : %s' % (self.count, self.size, self.stack_trace)
+ return '%d : %s' % (self.size, self.stack_trace)

Powered by Google App Engine
This is Rietveld 408576698