Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2232)

Unified Diff: Tools/GardeningServer/ui/ct-results-detail.html

Issue 549313005: Link to stdio output for compile failures. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/ct-results-detail.html
diff --git a/Tools/GardeningServer/ui/ct-results-detail.html b/Tools/GardeningServer/ui/ct-results-detail.html
index 1eef8a14105f66eef37959de6cf394bc4356c3b5..e172b429b1ce0010b2eb318b4f76f67a80cc8b7d 100644
--- a/Tools/GardeningServer/ui/ct-results-detail.html
+++ b/Tools/GardeningServer/ui/ct-results-detail.html
@@ -56,7 +56,8 @@ found in the LICENSE file.
var result = this.failure.resultNodesByBuilder[this.builder];
// FIXME: There's probably a less hacky way to check this.
- if (result.actual == 'FAIL' || result.actual == 'UNKNOWN')
+ if (result.actual == 'FAIL' || result.actual == 'UNKNOWN' ||
+ this.failure.step == 'compile')
this._updateUrls();
else
this._updateWebkitTestUrls();
@@ -94,7 +95,8 @@ found in the LICENSE file.
// FIXME: We only store build logs by the test name, not the testsuite.testname,
// which means that two failing tests from different test suites conflict!
- var testPart = result.actual == 'UNKNOWN' ? 'stdio' : this.failure.testName.split('.')[1];
+ var use_stdio = result.actual == 'UNKNOWN' || this.failure.step == 'compile';
ojan 2014/09/11 01:58:41 Lets make a helper function to avoid code duplicat
+ var testPart = use_stdio ? 'stdio' : this.failure.testName.split('.')[1];
var url = result.masterUrl +
'/builders/' + encodeURIComponent(this.builder) +
'/builds/' + result.lastFailingBuild +
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698