chrome/browser/chromeos/policy/device_local_account_external_data_service.cc - Issue 549313004: Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/policy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_local_account_external_data_service.cc

Issue 549313004: Remove implicit conversions from scoped_refptr to T* in c/b/chromeos/policy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc ('k') | chrome/browser/chromeos/policy/device_local_account_policy_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/device_local_account_external_data_service.cc

diff --git a/chrome/browser/chromeos/policy/device_local_account_external_data_service.cc b/chrome/browser/chromeos/policy/device_local_account_external_data_service.cc

index 9bc0f72bb1fd1096710b710a9da36d81aacdbbc4..c08094fd72d3779c668b8aef96a2bfcb99aca1e6 100644

--- a/chrome/browser/chromeos/policy/device_local_account_external_data_service.cc

+++ b/chrome/browser/chromeos/policy/device_local_account_external_data_service.cc

@@ -73,7 +73,7 @@ scoped_refptr<DeviceLocalAccountExternalDataManager>

CloudPolicyStore* policy_store) {

scoped_refptr<DeviceLocalAccountExternalDataManager>& external_data_manager =

external_data_managers_[account_id];

- if (!external_data_manager) {

+ if (!external_data_manager.get()) {

external_data_manager = new DeviceLocalAccountExternalDataManager(

account_id,

base::Bind(&GetChromePolicyDetails),