chrome/browser/invalidation/invalidation_service_android.cc - Issue 54923003: Support for shared invalidator client IDs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/invalidation/invalidation_service_android.cc

Issue 54923003: Support for shared invalidator client IDs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compile issue Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/invalidation/invalidation_service_android.cc

diff --git a/chrome/browser/invalidation/invalidation_service_android.cc b/chrome/browser/invalidation/invalidation_service_android.cc

index 72a7046d3e8ac94bee14d7ac75741c5c8c7a0635..4bada4b4baaba6ba03a266c51bca5688987e143e 100644

--- a/chrome/browser/invalidation/invalidation_service_android.cc

+++ b/chrome/browser/invalidation/invalidation_service_android.cc

@@ -59,8 +59,7 @@ InvalidationServiceAndroid::GetInvalidatorState() const {

std::string InvalidationServiceAndroid::GetInvalidatorClientId() const {

DCHECK(CalledOnValidThread());

- // TODO: Return a valid ID here. See crbug.com/172391.

- return "Bogus";

+ return invalidation_controller_->GetInvalidatorClientId();

}

void InvalidationServiceAndroid::Observe(