Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 549223003: Reland of Teach bot_update to support patching deps in solutions other than the patch_root (Closed)

Created:
6 years, 3 months ago by hinoka
Modified:
6 years, 3 months ago
Reviewers:
Ryan Tseng, agable, iannucci
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Reland of Teach bot_update to support patching deps in solutions other than the patch_root Original CL: https://codereview.chromium.org/552763002/ With one fix - patch_root is sometimes None, so it should be defaulted to a string so that string concat doesn't raise an error. BUG=411434 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291864

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M scripts/slave/bot_update.py View 1 2 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ryan Tseng
PS1 = old CL, PS2 = this CL
6 years, 3 months ago (2014-09-08 20:43:33 UTC) #2
agable
On 2014/09/08 20:43:33, Ryan T. (EMEA time) wrote: > PS1 = old CL, PS2 = ...
6 years, 3 months ago (2014-09-08 20:46:36 UTC) #3
agable
On 2014/09/08 20:46:36, agable wrote: > On 2014/09/08 20:43:33, Ryan T. (EMEA time) wrote: > ...
6 years, 3 months ago (2014-09-08 20:46:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@chromium.org/549223003/20001
6 years, 3 months ago (2014-09-08 20:51:54 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 20:53:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 291864

Powered by Google App Engine
This is Rietveld 408576698