 Chromium Code Reviews
 Chromium Code Reviews Issue 549213004:
  [Mac] Implement a new WebSandboxSupport method to get the display's color space.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 549213004:
  [Mac] Implement a new WebSandboxSupport method to get the display's color space.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: content/renderer/renderer_webkitplatformsupport_impl.cc | 
| diff --git a/content/renderer/renderer_webkitplatformsupport_impl.cc b/content/renderer/renderer_webkitplatformsupport_impl.cc | 
| index 797285fc125d7174fbad4aca78548e04c28492f9..e607b5c3e3ff83ad21d0b9932ed7925bc64e3746 100644 | 
| --- a/content/renderer/renderer_webkitplatformsupport_impl.cc | 
| +++ b/content/renderer/renderer_webkitplatformsupport_impl.cc | 
| @@ -84,6 +84,7 @@ | 
| #endif | 
| #if defined(OS_MACOSX) | 
| +#include "base/mac/mac_util.h" | 
| #include "content/common/mac/font_descriptor.h" | 
| #include "content/common/mac/font_loader.h" | 
| #include "content/renderer/webscrollbarbehavior_impl_mac.h" | 
| @@ -202,6 +203,7 @@ class RendererWebKitPlatformSupportImpl::SandboxSupport | 
| NSFont* src_font, | 
| CGFontRef* container, | 
| uint32* font_id); | 
| + virtual CGColorSpaceRef displayColorSpace(); | 
| #elif defined(OS_POSIX) | 
| virtual void getFallbackFontForCharacter( | 
| blink::WebUChar32 character, | 
| @@ -573,6 +575,11 @@ bool RendererWebKitPlatformSupportImpl::SandboxSupport::loadFont( | 
| return FontLoader::CGFontRefFromBuffer(font_data, font_data_size, out); | 
| } | 
| +CGColorSpaceRef | 
| +RendererWebKitPlatformSupportImpl::SandboxSupport::displayColorSpace() { | 
| + return base::mac::GetSystemColorSpace(); | 
| 
Noel Gordon
2014/09/10 07:35:37
This could be called on an arbitrary thread, such
 
Noel Gordon
2014/09/10 07:52:50
And it seems we're not; the other code review 
ht
 
Robert Sesek
2014/09/10 14:34:12
That has nothing to do with thread safety. There's
 | 
| +} | 
| + | 
| #elif defined(OS_ANDROID) | 
| // WebKit doesn't use WebSandboxSupport on android so we don't need to |