Issue 549183002: Let .skps have Expectations (i.e. work with -r) too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 549183002: Let .skps have Expectations (i.e. work with -r) too. (Closed)

Created:
6 years, 3 months ago by mtklein_C

Modified:
6 years, 3 months ago

Reviewers:
jcgregorio, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Let .skps have Expectations (i.e. work with -r) too. BUG=skia: Committed: https://skia.googlesource.com/skia/+/23c94f05cad79f6f8d303c1b4ffb6d0b91671e83

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -6 lines)			Patch
M	dm/DM.cpp	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	dm/DMSKPTask.h	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	dm/DMSKPTask.cpp	View	3 chunks	+11 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

jcgregorio

On 2014/09/08 15:56:15, mtklein wrote: LGTM So little code to change, nice!

6 years, 3 months ago (2014-09-08 16:02:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/549183002/1

6 years, 3 months ago (2014-09-08 16:05:56 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-08 16:12:31 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 23c94f05cad79f6f8d303c1b4ffb6d0b91671e83