Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 549153005: Fix format of nanobench result (Closed)

Created:
6 years, 3 months ago by qiankun
Modified:
6 years, 3 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix format of nanobench result Column of samples is too wide. This makes config is not align with the 'config' title. Pad 'samples' tilte with some whitespaces to fix this issue. BUG=skia: Committed: https://skia.googlesource.com/skia/+/8247ec313d87afcdd4da59b1f2f0d24e0983e359

Patch Set 1 #

Total comments: 2

Patch Set 2 : for any number of samples #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M bench/nanobench.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
qiankun
PTAL.
6 years, 3 months ago (2014-09-09 08:44:06 UTC) #2
mtklein
https://codereview.chromium.org/549153005/diff/1/bench/nanobench.cpp File bench/nanobench.cpp (right): https://codereview.chromium.org/549153005/diff/1/bench/nanobench.cpp#newcode590 bench/nanobench.cpp:590: SkDebugf("maxrss\tloops\tmin\tmedian\tmean\tmax\tstddev\tsamples \tconfig\tbench\n"); How about this? SkDebugf("maxrss\tloops\tmin\tmedian\tmean\tmax\tstddev\t%*s\tconfig\tbench\n", FLAGS_samples, "samples"); That ...
6 years, 3 months ago (2014-09-09 17:34:10 UTC) #3
qiankun
https://codereview.chromium.org/549153005/diff/1/bench/nanobench.cpp File bench/nanobench.cpp (right): https://codereview.chromium.org/549153005/diff/1/bench/nanobench.cpp#newcode590 bench/nanobench.cpp:590: SkDebugf("maxrss\tloops\tmin\tmedian\tmean\tmax\tstddev\tsamples \tconfig\tbench\n"); On 2014/09/09 17:34:10, mtklein wrote: > How ...
6 years, 3 months ago (2014-09-10 01:47:08 UTC) #4
mtklein
lgtm
6 years, 3 months ago (2014-09-10 02:09:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/qiankun.miao@intel.com/549153005/20001
6 years, 3 months ago (2014-09-10 02:10:31 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:24:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 8247ec313d87afcdd4da59b1f2f0d24e0983e359

Powered by Google App Engine
This is Rietveld 408576698