Issue 549133002: Fix lower bound in JSLoadContext typer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 549133002: Fix lower bound in JSLoadContext typer. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger

Modified:
6 years, 3 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix lower bound in JSLoadContext typer. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23777

Patch Set 2 : Addressed comments by Andreas Rossberg. #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -6 lines)			Patch
	M	src/compiler/typer.cc	View	1	3 chunks	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rossberg

LGTM modulo comment https://codereview.chromium.org/549133002/diff/1/src/compiler/typer.cc File src/compiler/typer.cc (right): https://codereview.chromium.org/549133002/diff/1/src/compiler/typer.cc#newcode510 src/compiler/typer.cc:510: } else if (context_type->IsConstant()) { I ...

6 years, 3 months ago (2014-09-08 14:04:22 UTC) #2

Michael Starzinger

Addressed comments. Landing. https://codereview.chromium.org/549133002/diff/1/src/compiler/typer.cc File src/compiler/typer.cc (right): https://codereview.chromium.org/549133002/diff/1/src/compiler/typer.cc#newcode510 src/compiler/typer.cc:510: } else if (context_type->IsConstant()) { On ...

6 years, 3 months ago (2014-09-08 14:28:51 UTC) #3

Michael Starzinger

6 years, 3 months ago (2014-09-08 14:32:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 23777 (presubmit successful).

Expand Messages | Collapse Messages

Issue 549133002: Fix lower bound in JSLoadContext typer. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments by Andreas Rossberg. #

Messages