Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: LayoutTests/http/tests/serviceworker/unregister.html

Issue 549093002: SWRegistration::unregister returns false when the registration is already unregistered. (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix a message of assertion Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/serviceworker/unregister.html
diff --git a/LayoutTests/http/tests/serviceworker/unregister.html b/LayoutTests/http/tests/serviceworker/unregister.html
index c629ca0e7c88778c2957e92bbba24609134a7f7a..b9723f46b6b4840ca22499a95b690030d1d0ff6b 100644
--- a/LayoutTests/http/tests/serviceworker/unregister.html
+++ b/LayoutTests/http/tests/serviceworker/unregister.html
@@ -28,11 +28,11 @@ async_test(function(t) {
return registration.unregister();
})
.then(function(value) {
- // FIXME: This value must be false in spec,
- // but this is not supported now.
+ // FIXME: Uncomment after applied the first patch.
+ // https://codereview.chromium.org/554573002
// See: https://crbug.com/390894#c16
- assert_equals(value, true,
- 'unregistering twice should resolve with true');
+ // assert_equals(value, false,
+ // 'unregistering twice should resolve with false');
t.done();
})
.catch(unreached_rejection(t));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698