Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 549093002: SWRegistration::unregister returns false when the registration is already unregistered. (1/3) (Closed)

Created:
6 years, 3 months ago by shimazu
Modified:
6 years, 3 months ago
Reviewers:
horo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

ServiceWorkerRegistration::unregister returns false when the registration is already unregistered. (1/3) 1. [Blink] this patch 2. [Chromium] https://codereview.chromium.org/554573002/ 3. [Blink] https://codereview.chromium.org/550093002/ BUG=390894 TEST=run_webkit_tests.py http/tests/serviceworker/unregister.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181692

Patch Set 1 #

Patch Set 2 : Fix a message of assertion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M LayoutTests/http/tests/serviceworker/unregister.html View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shimazu
6 years, 3 months ago (2014-09-08 08:26:38 UTC) #2
horo
Please set shorter subject to this issue. LGTM
6 years, 3 months ago (2014-09-08 12:14:42 UTC) #3
nhiroki
drive-by-comment (you don't have to wait for my further comment): Regarding the commit subject, the ...
6 years, 3 months ago (2014-09-08 12:37:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shimazu@chromium.org/549093002/20001
6 years, 3 months ago (2014-09-10 00:34:50 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 01:52:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181692

Powered by Google App Engine
This is Rietveld 408576698