Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: chrome/browser/resources/options/website_settings.js

Issue 549083005: Fix an error where the onchange() only worked due to scoping rules. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 /** @const */ var Page = cr.ui.pageManager.Page; 6 /** @const */ var Page = cr.ui.pageManager.Page;
7 /** @const */ var PageManager = cr.ui.pageManager.PageManager; 7 /** @const */ var PageManager = cr.ui.pageManager.PageManager;
8 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel; 8 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
9 9
10 ///////////////////////////////////////////////////////////////////////////// 10 /////////////////////////////////////////////////////////////////////////////
(...skipping 21 matching lines...) Expand all
32 */ 32 */
33 originList_: null, 33 originList_: null,
34 34
35 /** @override */ 35 /** @override */
36 initializePage: function() { 36 initializePage: function() {
37 Page.prototype.initializePage.call(this); 37 Page.prototype.initializePage.call(this);
38 38
39 $('website-settings-overlay-confirm').onclick = 39 $('website-settings-overlay-confirm').onclick =
40 PageManager.closeOverlay.bind(PageManager); 40 PageManager.closeOverlay.bind(PageManager);
41 41
42 $('resourceType').onchange = function() { 42 $('resourceType').onchange = function(event) {
43 var target = event.target; 43 var target = event.target;
44 assert(target.tagName == 'SELECT'); 44 assert(target.tagName == 'SELECT');
45 if (target.value == 'storage') 45 if (target.value == 'storage')
46 chrome.send('updateLocalStorage'); 46 chrome.send('updateLocalStorage');
47 else if (target.value == 'battery') 47 else if (target.value == 'battery')
48 chrome.send('updateBatteryUsage'); 48 chrome.send('updateBatteryUsage');
49 else 49 else
50 chrome.send('updateOrigins', [target.value]); 50 chrome.send('updateOrigins', [target.value]);
51 }; 51 };
52 52
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 128
129 WebsiteSettingsManager.showEditPage = function(url) { 129 WebsiteSettingsManager.showEditPage = function(url) {
130 WebsiteSettingsEditor.getInstance().populatePage(url); 130 WebsiteSettingsEditor.getInstance().populatePage(url);
131 }; 131 };
132 132
133 // Export 133 // Export
134 return { 134 return {
135 WebsiteSettingsManager: WebsiteSettingsManager 135 WebsiteSettingsManager: WebsiteSettingsManager
136 }; 136 };
137 }); 137 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698