Issue 549083004: Revert r23732 ("ARM64: Fix and improve --trace-sim register trace.") and r23733 ("ARM64: Fix build …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 549083004: Revert r23732 ("ARM64: Fix and improve --trace-sim register trace.") and r23733 ("ARM64: Fix build … (Closed)

Created:
6 years, 3 months ago by Sven Panne

Modified:
6 years, 3 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Revert r23732 ("ARM64: Fix and improve --trace-sim register trace.") and r23733 ("ARM64: Fix build warning in r23732.) They break the build when compiling with optimizations, e.g. optdebug: ../src/arm64/simulator-arm64.cc: In member function ‘void v8::internal::Simulator::PrintWriteFP(uintptr_t, size_t, unsigned int)’: ../src/arm64/simulator-arm64.cc:792:29: error: array subscript is above array bounds [-Werror=array-bounds] ../src/arm64/simulator-arm64.cc:799:29: error: array subscript is above array bounds [-Werror=array-bounds] TBR=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23765

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+227 lines, -470 lines)			Patch
M	src/arm64/disasm-arm64.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/arm64/instructions-arm64.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/arm64/simulator-arm64.h	View	9 chunks	+40 lines, -111 lines	0 comments	Download
M	src/arm64/simulator-arm64.cc	View	28 chunks	+184 lines, -354 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

6 years, 3 months ago (2014-09-08 08:25:57 UTC) #2

Message was sent while issue was closed.

On 2014/09/08 08:23:13, Sven Panne wrote:
> Committed patchset #1 (id:1) manually as 23765.

lgtm.

Expand Messages | Collapse Messages